Update Combo and Simple Combo Keyboard Navigation & Add Escape Key behavior #16246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates keyboard navigation for Combo and Simple Combo components by adding Escape key behavior and improving Tab key handling. When the dropdown is collapsed, pressing Escape now clears the selection. When the dropdown is open, pressing Escape closes it. Tab key behavior is refined to properly close the dropdown and move focus to the next element.
Key changes:
- Added Escape key handler to clear selection when combo is collapsed and close dropdown when open
- Modified Tab key handling to prevent default behavior only for navigation keys (excluding Tab)
- Removed keyboard event handlers from clear and toggle buttons, simplifying the interaction model
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| simple-combo.component.ts | Added Escape key handler and consolidated clear button logic |
| simple-combo.component.spec.ts | Added tests for Escape key behavior and updated Tab key test |
| simple-combo.component.html | Removed keyboard handlers and tabindex from clear/toggle buttons |
| combo.component.ts | Added Escape key handler and consolidated clear button logic |
| combo.component.spec.ts | Added tests for Escape and Tab key behaviors |
| combo.component.html | Removed keyboard handlers and tabindex from clear/toggle buttons |
| combo.common.ts | Enhanced close handler to detect Tab key and refocus input |
| combo-dropdown.component.ts | Separated Tab and Escape key handling in action handler |
| drop-down-navigation.directive.ts | Updated to allow Tab key default behavior |
| query-builder-functions.spec.ts | Updated test expectations after toggle button removal from tab order |
| CHANGELOG.md | Documented new keyboard navigation features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.spec.ts
Outdated
Show resolved
Hide resolved
Lipata
previously approved these changes
Oct 27, 2025
…into mkirkova/combo-navigation-16223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16223
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)